diff options
| author | Michael Haggerty <mhagger@alum.mit.edu> | 2010-01-14 06:54:50 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-01-14 00:27:56 -0800 |
| commit | f99e269c44a7f07699a92c7e31d31ed93dafb409 (patch) | |
| tree | 77083a03328716f07c5b94444a598ed14bbac62d /git-rebase--interactive.sh | |
| parent | 5065ed296abc1c0b66ad7c5e963e048cb90b6ee6 (diff) | |
| download | git-f99e269c44a7f07699a92c7e31d31ed93dafb409.tar.gz git-f99e269c44a7f07699a92c7e31d31ed93dafb409.tar.xz | |
rebase -i: Simplify commit counting for generated commit messages
Read the old count from the first line of the old commit message
rather than counting the number of commit message blocks in the file.
This is simpler, faster, and more robust (e.g., it cannot be confused
by strange commit message contents).
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-rebase--interactive.sh')
| -rwxr-xr-x | git-rebase--interactive.sh | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 702c97941..d60e05983 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -349,11 +349,9 @@ nth_string () { make_squash_message () { if test -f "$SQUASH_MSG"; then - # We want to be careful about matching only the commit - # message comment lines generated by this function. - # "[snrt][tdh]" matches the nth_string endings. - COUNT=$(($(sed -n "s/^# Th[^0-9]*\([1-9][0-9]*\)[snrt][tdh] commit message.*:/\1/p" \ - < "$SQUASH_MSG" | sed -ne '$p')+1)) + COUNT=$(($(sed -n \ + -e "1s/^# This is a combination of \(.*\) commits\./\1/p" \ + -e "q" < "$SQUASH_MSG")+1)) echo "# This is a combination of $COUNT commits." sed -e 1d -e '2,/^./{ /^$/d @@ -376,9 +374,6 @@ make_squash_message () { echo echo "# The $(nth_string $COUNT) commit message will be skipped:" echo - # Comment the lines of the commit message out using - # "# " rather than "# " to make them less likely to - # confuse the sed regexp above. git cat-file commit $2 | sed -e '1,/^$/d' -e 's/^/# /' ;; esac |