aboutsummaryrefslogtreecommitdiff
path: root/imap-send.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2017-09-25 16:27:17 -0400
committerJunio C Hamano <gitster@pobox.com>2017-09-26 12:54:43 +0900
commit88780c37b314d783db09118179ceba30096ef935 (patch)
tree0008a1e9925c7fcb65a34aee9e210ec11654b773 /imap-send.c
parentc50424a6f07f17ff9b06927606df650cd73a09a3 (diff)
downloadgit-88780c37b314d783db09118179ceba30096ef935.tar.gz
git-88780c37b314d783db09118179ceba30096ef935.tar.xz
files-backend: prefer "0" for write_in_full() error check
Commit 06f46f237a (avoid "write_in_full(fd, buf, len) != len" pattern, 2017-09-13) converted this callsite from: write_in_full(...) != 1 to write_in_full(...) < 0 But during the conflict resolution in c50424a6f0 (Merge branch 'jk/write-in-full-fix', 2017-09-25), this morphed into write_in_full(...) < 1 This behaves as we want, but we prefer to avoid modeling the "less than length" error-check which can be subtly buggy, as shown in efacf609c8 (config: avoid "write_in_full(fd, buf, len) < len" pattern, 2017-09-13). Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'imap-send.c')
0 files changed, 0 insertions, 0 deletions