diff options
| author | Jeff King <peff@peff.net> | 2017-05-20 04:30:25 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-05-20 18:32:58 +0900 |
| commit | a3ba6bf10abcaed1819d27fa45675c3a0e141f95 (patch) | |
| tree | c12010db2c18156130f55cdc36a8d369da4817d5 /revision.c | |
| parent | 840ed141983718e0c5518a325534a5656797132a (diff) | |
| download | git-a3ba6bf10abcaed1819d27fa45675c3a0e141f95.tar.gz git-a3ba6bf10abcaed1819d27fa45675c3a0e141f95.tar.xz | |
revision.c: ignore broken tags with ignore_missing_links
When peeling a tag for prepare_revision_walk(), we do not
respect the ignore_missing_links flag. This can lead to a
bogus error when pack-objects walks the possibly-broken
unreachable-but-recent part of the object graph.
The other link-following all happens via traverse_commit_list(),
which explains why this case was missed. And our tests
covered only broken links from commits. Let's be more
comprehensive and cover broken tree entries (which do work)
and tags (which shows off this bug).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
| -rw-r--r-- | revision.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/revision.c b/revision.c index 8a29cb03c..7d57d440a 100644 --- a/revision.c +++ b/revision.c @@ -230,7 +230,7 @@ static struct commit *handle_commit(struct rev_info *revs, die("bad tag"); object = parse_object(tag->tagged->oid.hash); if (!object) { - if (flags & UNINTERESTING) + if (revs->ignore_missing_links || (flags & UNINTERESTING)) return NULL; die("bad object %s", oid_to_hex(&tag->tagged->oid)); } |