diff options
| author | Jeff King <peff@peff.net> | 2016-06-13 06:04:20 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-06-13 10:37:51 -0700 |
| commit | 2721ce21e439ee0726dc69073acd7e0d2b2407b3 (patch) | |
| tree | 204966369741352a8abc9651805ed0c88677598f /t/helper | |
| parent | 7013220d2b3181d4ae55e21e0f18b9abfd6e011d (diff) | |
| download | git-2721ce21e439ee0726dc69073acd7e0d2b2407b3.tar.gz git-2721ce21e439ee0726dc69073acd7e0d2b2407b3.tar.xz | |
use string_list initializer consistently
There are two types of string_lists: those that own the
string memory, and those that don't. You can tell the
difference by the strdup_strings flag, and one should use
either STRING_LIST_INIT_DUP, or STRING_LIST_INIT_NODUP as an
initializer.
Historically, the normal all-zeros initialization has
corresponded to the NODUP case. Many sites use no
initializer at all, and that works as a shorthand for that
case. But for a reader of the code, it can be hard to
remember which is which. Let's be more explicit and actually
have each site declare which type it means to use.
This is a fairly mechanical conversion; I assumed each site
was correct as-is, and just switched them all to NODUP.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/helper')
| -rw-r--r-- | t/helper/test-parse-options.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/helper/test-parse-options.c b/t/helper/test-parse-options.c index 2c8c8f18e..37a196781 100644 --- a/t/helper/test-parse-options.c +++ b/t/helper/test-parse-options.c @@ -11,7 +11,7 @@ static int verbose = 0, dry_run = 0, quiet = 0; static char *string = NULL; static char *file = NULL; static int ambiguous; -static struct string_list list; +static struct string_list list = STRING_LIST_INIT_NODUP; static int length_callback(const struct option *opt, const char *arg, int unset) { |