diff options
| author | Junio C Hamano <gitster@pobox.com> | 2008-05-23 22:28:56 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-05-24 00:01:56 -0700 |
| commit | 3af828634fa5bdbca1b2061a81df8b3fa73b0d34 (patch) | |
| tree | f4d4a50e8c1686b3ecd796a09f98cc6ca13bc907 /t/t3002-ls-files-dashpath.sh | |
| parent | 998b912927281a871e8d379e2b3a4385c775c4fe (diff) | |
| download | git-3af828634fa5bdbca1b2061a81df8b3fa73b0d34.tar.gz git-3af828634fa5bdbca1b2061a81df8b3fa73b0d34.tar.xz | |
tests: do not use implicit "git diff --no-index"
As a general principle, we should not use "git diff" to validate the
results of what git command that is being tested has done. We would not
know if we are testing the command in question, or locating a bug in the
cute hack of "git diff --no-index".
Rather use test_cmp for that purpose.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t3002-ls-files-dashpath.sh')
| -rwxr-xr-x | t/t3002-ls-files-dashpath.sh | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/t/t3002-ls-files-dashpath.sh b/t/t3002-ls-files-dashpath.sh index 8687a01d2..8704b04e1 100755 --- a/t/t3002-ls-files-dashpath.sh +++ b/t/t3002-ls-files-dashpath.sh @@ -23,7 +23,7 @@ test_expect_success \ test_expect_success \ 'git ls-files without path restriction.' \ 'git ls-files --others >output && - git diff output - <<EOF + test_cmp output - <<EOF -- -foo output @@ -34,7 +34,7 @@ EOF test_expect_success \ 'git ls-files with path restriction.' \ 'git ls-files --others path0 >output && - git diff output - <<EOF + test_cmp output - <<EOF path0 EOF ' @@ -42,7 +42,7 @@ EOF test_expect_success \ 'git ls-files with path restriction with --.' \ 'git ls-files --others -- path0 >output && - git diff output - <<EOF + test_cmp output - <<EOF path0 EOF ' @@ -50,7 +50,7 @@ EOF test_expect_success \ 'git ls-files with path restriction with -- --.' \ 'git ls-files --others -- -- >output && - git diff output - <<EOF + test_cmp output - <<EOF -- EOF ' @@ -58,7 +58,7 @@ EOF test_expect_success \ 'git ls-files with no path restriction.' \ 'git ls-files --others -- >output && - git diff output - <<EOF + test_cmp output - <<EOF -- -foo output |