diff options
| author | Jani Nikula <ext-jani.1.nikula@nokia.com> | 2010-06-01 15:12:12 +0300 |
|---|---|---|
| committer | Tomi Valkeinen <tomi.valkeinen@nokia.com> | 2010-08-05 16:52:08 +0300 |
| commit | 9325588757aa7d08bf2ca9c63b669d0d7aa2fc40 (patch) | |
| tree | 4fc5823cb5cdf06ecd0baeedc99ae4ac6f6f41ed | |
| parent | ffb63c95b2fa52b02b45537d18f0ca698bef5496 (diff) | |
| download | linux-9325588757aa7d08bf2ca9c63b669d0d7aa2fc40.tar.gz linux-9325588757aa7d08bf2ca9c63b669d0d7aa2fc40.tar.xz | |
OMAP: DSS2: OMAPFB: Check fb2display() return value
Make sure NULL return value of fb2display() is not referenced. Found by
Coverity.
Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
| -rw-r--r-- | drivers/video/omap2/omapfb/omapfb-ioctl.c | 2 | ||||
| -rw-r--r-- | drivers/video/omap2/omapfb/omapfb-main.c | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/drivers/video/omap2/omapfb/omapfb-ioctl.c b/drivers/video/omap2/omapfb/omapfb-ioctl.c index d1f56d37405f..994f6a091b49 100644 --- a/drivers/video/omap2/omapfb/omapfb-ioctl.c +++ b/drivers/video/omap2/omapfb/omapfb-ioctl.c @@ -858,7 +858,7 @@ int omapfb_ioctl(struct fb_info *fbi, unsigned int cmd, unsigned long arg) break; } - if (!display->driver->enable_te) { + if (!display || !display->driver->enable_te) { r = -ENODEV; break; } diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index a545e8d4817f..db307e3c1dd5 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -1271,6 +1271,9 @@ static int omapfb_blank(int blank, struct fb_info *fbi) int do_update = 0; int r = 0; + if (!display) + return -EINVAL; + omapfb_lock(fbdev); switch (blank) { |