diff options
author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2016-02-09 21:11:14 +0100 |
---|---|---|
committer | Doug Ledford <dledford@redhat.com> | 2016-02-11 11:04:54 -0500 |
commit | fa51b247d67b521e1a1103cad75eb7a666fc9ff9 (patch) | |
tree | bc1eeea96673e7aea80c4435cff6ca49a53fa82e /drivers/infiniband/core/sysfs.c | |
parent | 7425f410ca6cffe81400906286f80e8e15d9b301 (diff) | |
download | linux-fa51b247d67b521e1a1103cad75eb7a666fc9ff9.tar.gz linux-fa51b247d67b521e1a1103cad75eb7a666fc9ff9.tar.xz |
net/mlx4: fix some error handling in mlx4_multi_func_init()
The while loop after err_slaves should use post-decrement; otherwise
we'll fail to do the kfrees for i==0, and will run into out-of-bounds
accesses if the setup above failed already at i==0.
[I'm not sure why one even bothers populating the ->vlan_filter array:
mlx4.h isn't #included by anything outside
drivers/net/ethernet/mellanox/mlx4/, and "git grep -C2 -w vlan_filter
drivers/net/ethernet/mellanox/mlx4/" seems to suggest that the
vlan_filter elements aren't used at all.]
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/core/sysfs.c')
0 files changed, 0 insertions, 0 deletions