diff options
| author | Joel Stanley <joel@jms.id.au> | 2017-07-25 10:19:01 +0930 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-07-25 21:21:44 -0700 |
| commit | 6cee9d649cd1824a4d9ce6940dd716f2bf2ef24f (patch) | |
| tree | e885c6f6a78ff16d35e8595c393a407376371961 /drivers/net/hyperv | |
| parent | afce615aaabfbaad02550e75c0bec106dafa1adf (diff) | |
| download | linux-6cee9d649cd1824a4d9ce6940dd716f2bf2ef24f.tar.gz linux-6cee9d649cd1824a4d9ce6940dd716f2bf2ef24f.tar.xz | |
ftgmac100: return error in ftgmac100_alloc_rx_buf
The error paths set err, but it's not returned.
I wondered if we should fix all of the callers to check the returned
value, but Ben explains why the code is this way:
> Most call sites ignore it on purpose. There's nothing we can do if
> we fail to get a buffer at interrupt time, so we point the buffer to
> the scratch page so the HW doesn't DMA into lalaland and lose the
> packet.
>
> The one call site that tests and can fail is the one used when brining
> the interface up. If we fail to allocate at that point, we fail the
> ifup. But as you noticed, I do have a bug not returning the error.
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/hyperv')
0 files changed, 0 insertions, 0 deletions