diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-03-16 14:34:51 -0500 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2017-04-04 08:29:56 -0500 |
| commit | 1b497e6493c49bbb55c89f53562f7f853495e90d (patch) | |
| tree | 8f03770651df8363684a4ce8927685f6e4af8b07 /drivers/pci/dwc/pcie-designware-host.c | |
| parent | dbe4a09e8bbcf88809a8394d6a359d8cebd22a86 (diff) | |
| download | linux-1b497e6493c49bbb55c89f53562f7f853495e90d.tar.gz linux-1b497e6493c49bbb55c89f53562f7f853495e90d.tar.xz | |
PCI: dwc: Fix uninitialized variable in dw_handle_msi_irq()
The bug is that "val" is unsigned long but we only initialize 32 bits of
it. Then we test "if (val)" and that might be true not because we set the
bits but because some were never initialized.
Fixes: f342d940ee0e ("PCI: exynos: Add support for MSI")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/dwc/pcie-designware-host.c')
| -rw-r--r-- | drivers/pci/dwc/pcie-designware-host.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c index 6cdd41f06dea..aece2962defc 100644 --- a/drivers/pci/dwc/pcie-designware-host.c +++ b/drivers/pci/dwc/pcie-designware-host.c @@ -56,19 +56,20 @@ static struct irq_chip dw_msi_irq_chip = { /* MSI int handler */ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp) { - unsigned long val; + u32 val; int i, pos, irq; irqreturn_t ret = IRQ_NONE; for (i = 0; i < MAX_MSI_CTRLS; i++) { dw_pcie_rd_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, 4, - (u32 *)&val); + &val); if (!val) continue; ret = IRQ_HANDLED; pos = 0; - while ((pos = find_next_bit(&val, 32, pos)) != 32) { + while ((pos = find_next_bit((unsigned long *) &val, 32, + pos)) != 32) { irq = irq_find_mapping(pp->irq_domain, i * 32 + pos); dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, 4, 1 << pos); |