diff options
author | Shaohua Li <shli@fb.com> | 2017-10-06 17:55:59 -0700 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2017-10-10 13:48:14 -0600 |
commit | eca8b53a6769e60d6d8240d71202d73b0af81901 (patch) | |
tree | 6a042bf2b35595851ca83b9e77eec8ca05f1e38a /include/linux/blk_types.h | |
parent | 53cfdc10a95d03fbc82970d682a32696d19ef886 (diff) | |
download | linux-eca8b53a6769e60d6d8240d71202d73b0af81901.tar.gz linux-eca8b53a6769e60d6d8240d71202d73b0af81901.tar.xz |
blk-stat: delete useless code
Fix two issues:
- the per-cpu stat flush is unnecessary, nobody uses per-cpu stat except
sum it to global stat. We can do the calculation there. The flush just
wastes cpu time.
- some fields are signed int/s64. I don't see the point.
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'include/linux/blk_types.h')
-rw-r--r-- | include/linux/blk_types.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index a2d2aa709cef..3385c89f402e 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -329,11 +329,10 @@ static inline bool blk_qc_t_is_internal(blk_qc_t cookie) } struct blk_rq_stat { - s64 mean; + u64 mean; u64 min; u64 max; - s32 nr_samples; - s32 nr_batch; + u32 nr_samples; u64 batch; }; |