diff options
| author | Mathias Krause <minipli@googlemail.com> | 2017-08-26 17:08:57 +0200 |
|---|---|---|
| committer | Steffen Klassert <steffen.klassert@secunet.com> | 2017-08-28 10:58:02 +0200 |
| commit | 5fe0d4bd8f86d19f7f24c1ae5a9b6e6a5a52e51a (patch) | |
| tree | a09063c857fe5f1ad3fb5f2e6cdf7f64f6f6df95 /net/xfrm/xfrm_user.c | |
| parent | 54ffd790792898f05e215dce5aa593473e80e92f (diff) | |
| download | linux-5fe0d4bd8f86d19f7f24c1ae5a9b6e6a5a52e51a.tar.gz linux-5fe0d4bd8f86d19f7f24c1ae5a9b6e6a5a52e51a.tar.xz | |
xfrm_user: fix info leak in copy_user_offload()
The memory reserved to dump the xfrm offload state includes padding
bytes of struct xfrm_user_offload added by the compiler for alignment.
Add an explicit memset(0) before filling the buffer to avoid the heap
info leak.
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net/xfrm/xfrm_user.c')
| -rw-r--r-- | net/xfrm/xfrm_user.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 2be4c6af008a..3259555ae7d7 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -796,7 +796,7 @@ static int copy_user_offload(struct xfrm_state_offload *xso, struct sk_buff *skb return -EMSGSIZE; xuo = nla_data(attr); - + memset(xuo, 0, sizeof(*xuo)); xuo->ifindex = xso->dev->ifindex; xuo->flags = xso->flags; |